Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Refactor: use configurable mixin for identical functionality on… #16

Open
wants to merge 5 commits into
base: 14.0-sale_configurator_option_report
Choose a base branch
from

Conversation

kevinkhao
Copy link
Contributor

… invoices and sale orders

@kevinkhao kevinkhao force-pushed the 14.0-refactor_invoices branch 5 times, most recently from 282e1ab to c0bb086 Compare February 19, 2021 15:11
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #16 (bab040e) into 14.0-sale_configurator_option_report (4f40f46) will increase coverage by 1.96%.
The diff coverage is 90.32%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           14.0-sale_configurator_option_report      #16      +/-   ##
========================================================================
+ Coverage                                 76.76%   78.72%   +1.96%     
========================================================================
  Files                                        17       19       +2     
  Lines                                       396      456      +60     
========================================================================
+ Hits                                        304      359      +55     
- Misses                                       92       97       +5     
Impacted Files Coverage Δ
sale_configurator_option/models/account_move.py 36.84% <ø> (ø)
sale_configurator_option/models/sale.py 93.75% <ø> (-0.13%) ⬇️
sale_configurator_base/models/account_move_line.py 89.65% <88.88%> (-10.35%) ⬇️
sale_configurator_base/models/sale.py 66.10% <90.00%> (-8.13%) ⬇️
...ale_configurator_base/models/configurable_mixin.py 90.41% <90.41%> (ø)
...e_configurator_option/models/configurable_mixin.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f40f46...bab040e. Read the comment docs.

@kevinkhao kevinkhao force-pushed the 14.0-sale_configurator_option_report branch from f8cfad3 to fd9b88a Compare March 1, 2021 15:16
@kevinkhao kevinkhao force-pushed the 14.0-refactor_invoices branch from 3ad87ad to f29262e Compare March 3, 2021 14:21
@kevinkhao kevinkhao force-pushed the 14.0-sale_configurator_option_report branch from fd9b88a to 4f40f46 Compare March 3, 2021 14:37
@kevinkhao kevinkhao force-pushed the 14.0-refactor_invoices branch from f29262e to bab040e Compare March 3, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant